Finish up #129 BOLT 7 compliance #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original macro is from Antoine Riard <[email protected]>, the error type and additional mappings are from Matt Corallo <[email protected]>
Original version is from Antoine Riard <[email protected]>, the error type and some return type fixes are from Matt Corallo <[email protected]>
They are all just "its too early/late to get an announcement" errors so simply ignoring them and not sending an announce is fine
Because we've separated out channel closure from ErrorMessage returning we can return error messages in a few additional cases, like if the peer sent us a message for a channel they didn't own.
Mostly to add a big comment noting why we aren't "spec-compliant"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base on #147 this should close out BOLT 7 on #129 "with the exception of 0.1-tagged open issues" assuming lightning/bolts#474 and lightning/bolts#471 go through.