Test coverage for transaction_unconfirmed
#1481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
force-pushed
the
2022-05-new-chain-tests
branch
3 times, most recently
from
1ba1c6d to
640af71
Compare
Codecov Report
@@ Coverage Diff @@
## main #1481 +/- ##
==========================================
+ Coverage 90.89% 91.51% +0.62%
==========================================
Files 76 77 +1
Lines 42054 46787 +4733
Branches 42054 46787 +4733
==========================================
+ Hits 38223 42815 +4592
- Misses 3831 3972 +141
Continue to review full report at Codecov.
|
|
Tagging 108 because #1486 depends on this. |
lightning/src/ln/functional_tests.rs
Outdated
Comment on lines
1283
to
1284
| // Check we only broadcast 1 timeout tx | ||
| let claim_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().clone(); | ||
| assert_eq!(claim_txn.len(), 8); |
There was a problem hiding this comment.
Is this still checking that we only broadcast 1 timeout tx per the comment?
There was a problem hiding this comment.
Kinda? I mean we do broadcast one timeout tx per commitment, but, yea, I'm just gonna drop the comment its confusing.
lightning/src/ln/functional_tests.rs
Outdated
Comment on lines
2586
to
2609
| assert_eq!(node_txn.len(), 9); | ||
| assert!(node_txn.len() == 9 || node_txn.len() == 10); | ||
| // ChannelMonitor: justice tx revoked offered htlc, justice tx revoked received htlc, justice tx revoked to_local (3) | ||
| // ChannelManager: local commmitment + local HTLC-timeout (2) | ||
| // ChannelMonitor: bumped justice tx, after one increase, bumps on HTLC aren't generated not being substantial anymore, bump on revoked to_local isn't generated due to more room for expiration (2) |
There was a problem hiding this comment.
Are these comments enumerating the txs in node_txn? Do they need updating?
There was a problem hiding this comment.
I just dropped them. We aren't actually checking all those things so the comment is just going to get stale and confusing over time anyway.
|
I think a warning may have been introduced in |
TheBlueMatt
force-pushed
the
2022-05-new-chain-tests
branch
2 times, most recently
from
3936511 to
51a58a9
Compare
valentinewallace
previously approved these changes
May 17, 2022
Previously `transaction_unconfirmed` was never called in tests!
In the next commit we'll randomize the `ConnectStyle` used in each test. However, some tests are slightly too prescriptive, which we address here in a few places.
We have a bunch of fancy infrastructure to ensure we can connect blocks using all our different connection interfaces, but we only bother to use it in a few select tests. This expands our use of `ConnectStyle` to most of our tests by simply randomizing the style in each test. This makes our tests non-deterministic, but we print the connection style at start so that it's easy to reproduce a failure deterministically.
TheBlueMatt
force-pushed
the
2022-05-new-chain-tests
branch
from
51a58a9 to
b083870
Compare
|
Squashed without changes: |
wpaulino
approved these changes
May 26, 2022
valentinewallace
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed we have ~zero test coverage of the
transaction_unconfirmedAPI, which is somewhat frightening. This adds such coverage via a newConnectionStylein the functional tests and also randomizes theConnectionStyleused during functional tests, providing more coverage of the various connection methods generally.