Include inbound-claimed-HTLCs in reported channel balances #1268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1268 +/- ##
==========================================
+ Coverage 90.40% 91.96% +1.55%
==========================================
Files 71 71
Lines 38135 47519 +9384
==========================================
+ Hits 34476 43700 +9224
- Misses 3659 3819 +160
Continue to review full report at Codecov.
|
TheBlueMatt
force-pushed
the
2022-01-balance-underflow
branch
from
83588a3 to
584920c
Compare
|
Added a test, while adding it I discovered this is even harder to hit than I thought, you have to write a custom router on top and can only happen on the first HTLC after open cause otherwise the reserve value protects us against underflow. Would still be nice to land for 105, but its really hard to hit. |
valentinewallace
previously approved these changes
Feb 3, 2022
jkczyz
reviewed
Feb 7, 2022
arik-so
previously approved these changes
Feb 10, 2022
Given the balance is reported as "total balance if we went to chain ignoring fees", it seems reasonable to include claimed HTLCs - if we went to chain we'd get those funds, less on-chain fees. Further, if we do not include them, its possible to have pending outbound holding-cell HTLCs underflow the balance calculation, causing a panic in debug mode, and bogus values in release. This resolves a subtraction underflow bug found by the `chanmon_consistency` fuzz target.
TheBlueMatt
dismissed stale reviews from arik-so and valentinewallace
via
1818c4a
TheBlueMatt
force-pushed
the
2022-01-balance-underflow
branch
from
584920c to
1818c4a
Compare
jkczyz
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the balance is reported as "total balance if we went to chain
ignoring fees", it seems reasonable to include claimed HTLCs - if
we went to chain we'd get those funds, less on-chain fees. Further,
if we do not include them, its possible to have pending outbound
holding-cell HTLCs underflow the balance calculation, causing a
panic in debug mode, and bogus values in release.
This resolves a subtraction underflow bug found by the
chanmon_consistencyfuzz target.