Pre-0.0.103 Bindings Tweaks #1150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
force-pushed
the
2021-11-103-bindings
branch
from
ffd5518 to
1ca01a2
Compare
Codecov Report
@@ Coverage Diff @@
## main #1150 +/- ##
==========================================
- Coverage 90.14% 90.14% -0.01%
==========================================
Files 70 70
Lines 36384 36386 +2
==========================================
+ Hits 32800 32801 +1
- Misses 3584 3585 +1
Continue to review full report at Codecov.
|
valentinewallace
approved these changes
Nov 1, 2021
|
ACK 1ca01a2 mod CI |
TheBlueMatt
force-pushed
the
2021-11-103-bindings
branch
from
1ca01a2 to
b2e37c3
Compare
|
Oops, pushed a fixup commit for fuzzing and reordered the commits so things are correct. |
TheBlueMatt
force-pushed
the
2021-11-103-bindings
branch
from
b2e37c3 to
89c602c
Compare
This also differentiates it from the bindings default-constructed `new` method which is constructed when all fields are exposed and of mappable types.
The bindings don't currently support passing `Vec`s of objects which it mappes as "opaque types". This is because it will require clones to convert its own list of references to Rust's list of objects. In the near future we should resolve this limitation, allowing us to revert this (and make `find_route`'s method signature similarly cleaner), but for now we must avoid `Vec<OpaqueType>`.
This matches the other `Payee` move-modifier functions.
This prepares us for C bindings auto-exporting tuple type fields.
TheBlueMatt
force-pushed
the
2021-11-103-bindings
branch
from
89c602c to
0c1b70c
Compare
|
Rebased on latest upstream and squashed. |
valentinewallace
approved these changes
Nov 2, 2021
jkczyz
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some trivial tweaks and
(C-not exported)tags for bindings for 0.0.103, as well as some rustc warnings fixes for good measure.