Implement a "phase 2" API for sign_closing_transaction #1064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1064 +/- ##
==========================================
+ Coverage 90.87% 91.13% +0.25%
==========================================
Files 65 65
Lines 33229 34569 +1340
==========================================
+ Hits 30196 31503 +1307
- Misses 3033 3066 +33
Continue to review full report at Codecov.
|
TheBlueMatt
reviewed
Sep 2, 2021
lightning/src/ln/chan_utils.rs
Outdated
|
|
||
| if value_to_counterparty > 0 { | ||
| txouts.push((TxOut { | ||
| script_pubkey: counterparty_shutdown_script, |
There was a problem hiding this comment.
(here and in channel.rs) Calling this the "shutdown" script is a misnomer - the payout script is different from the shutdown one.
There was a problem hiding this comment.
I must've been high, I'm not sure what this means. Either script or shutdown_script are fine...
devrandom
force-pushed
the
2021-08-closing-tx-phase2
branch
from
f953f43 to
25d2e3e
Compare
TheBlueMatt
approved these changes
Sep 4, 2021
valentinewallace
approved these changes
Sep 8, 2021
devrandom
force-pushed
the
2021-08-closing-tx-phase2
branch
from
25d2e3e to
6a870a0
Compare
devrandom
force-pushed
the
2021-08-closing-tx-phase2
branch
from
6a870a0 to
eebc0a9
Compare
TheBlueMatt
approved these changes
Sep 9, 2021
valentinewallace
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the signer to figure out which output is ours without potentially complicated parsing.