Skip to content

Macroize feature printing to ensure we don't miss new flags #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TheBlueMatt
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #1020 (1f013c9) into main (1bb9e64) will decrease coverage by 0.02%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1020      +/-   ##
==========================================
- Coverage   90.81%   90.79%   -0.03%     
==========================================
  Files          60       60              
  Lines       31428    31434       +6     
==========================================
- Hits        28542    28541       -1     
- Misses       2886     2893       +7     
Impacted Files Coverage Δ
lightning/src/ln/features.rs 99.43% <92.30%> (-0.28%) ⬇️
lightning/src/ln/peer_handler.rs 45.98% <100.00%> (-0.47%) ⬇️
lightning/src/ln/functional_tests.rs 97.28% <0.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bb9e64...1f013c9. Read the comment docs.

Copy link
Contributor

@jkczyz jkczyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1f013c9

Was thinking we could use this lol

@TheBlueMatt
Copy link
Collaborator Author

Yea lol, I hacked it up to see if I had peers that wouldn't like #1018.

@TheBlueMatt TheBlueMatt merged commit f3b63e4 into lightningdevkit:main Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants