Skip to content

Conversation

@TheBlueMatt
Copy link
Collaborator

@TheBlueMatt TheBlueMatt commented Jul 22, 2021

Plus various small no_std bits, working towards no_std.

@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #1012 (0671ca6) into main (e26c9b0) will increase coverage by 0.04%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1012      +/-   ##
==========================================
+ Coverage   90.82%   90.86%   +0.04%     
==========================================
  Files          60       60              
  Lines       31455    31584     +129     
==========================================
+ Hits        28568    28698     +130     
+ Misses       2887     2886       -1     
Impacted Files Coverage Δ
lightning/src/ln/channelmanager.rs 85.89% <ø> (+0.32%) ⬆️
lightning-invoice/src/de.rs 80.73% <66.66%> (-0.34%) ⬇️
lightning-invoice/src/ser.rs 92.19% <100.00%> (ø)
lightning/src/chain/keysinterface.rs 95.36% <0.00%> (-0.05%) ⬇️
lightning/src/ln/functional_tests.rs 97.36% <0.00%> (-0.02%) ⬇️
lightning/src/ln/functional_test_utils.rs 95.74% <0.00%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e26c9b0...0671ca6. Read the comment docs.

Cargo.toml Outdated
lto = true

[patch.crates-io]
core2 = { git = "https://github.com/TheBlueMatt/core2", branch = "main" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still [DO NOT MERGE]?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, depends on technocreatives/core2#7. I guess we could just bump the CI MSRV version for no-std, but I don't see a reason to - gotta replace the std::io uses we have with core2 anyway before we can ship no-std, so its not like we're in a rush.

@TheBlueMatt TheBlueMatt force-pushed the 2021-07-bump-deps branch 3 times, most recently from e4a1ad8 to 0671ca6 Compare July 31, 2021 18:39
@TheBlueMatt
Copy link
Collaborator Author

Dropped the core2 patch since it seems like that isn't happening soon and just set the MSRV for no-std to stable instead for now. I think we can land this.

@devrandom
Copy link
Member

ACK

@devrandom
Copy link
Member

Interesting test failure though

@TheBlueMatt
Copy link
Collaborator Author

Interesting test failure though

The test failure is unrelated. rustc is (probably) going to make an incompatible libstd change soon, so we're failing on beta. I've argued a bit with them, but there's not really a great other way to accomplish what they want (more ErrorKind variants).

@TheBlueMatt
Copy link
Collaborator Author

This hasn't materially changed since @jkczyz's last review, just merging.

@TheBlueMatt TheBlueMatt merged commit bee9a1e into lightningdevkit:main Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants