Skip to content

Replace Channel::get_holder_max_htlc_value_in_flight_msat with configuration options #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TheBlueMatt opened this issue Mar 17, 2021 · 1 comment
Labels
good first issue Good for newcomers
Milestone

Comments

@TheBlueMatt
Copy link
Collaborator

We should have configuration options which allow controlling the output of Channel::get_holder_max_htlc_value_in_flight_msat in ChannelHandshakeConfig. I think the way to do this is to provide some kind of "min htlc_max_in_flight as a percentage of channel value" and "min htlc_max_in_filght absolute value" knobs and then calculate it in Channel::get_holder_max_htlc_value_in_flight_msat instead of hard-coding it, but I'm open to ideas.

@TheBlueMatt
Copy link
Collaborator Author

Done in #1444.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant