Skip to content

Replace Channel::get_holder_max_htlc_value_in_flight_msat with configuration options #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TheBlueMatt opened this issue Mar 17, 2021 · 1 comment
Closed

Replace Channel::get_holder_max_htlc_value_in_flight_msat with configuration options #850

TheBlueMatt opened this issue Mar 17, 2021 · 1 comment
Labels
good first issue Good for newcomers
Milestone
0.2

Comments

@TheBlueMatt
Copy link
Collaborator

We should have configuration options which allow controlling the output of Channel::get_holder_max_htlc_value_in_flight_msat in ChannelHandshakeConfig. I think the way to do this is to provide some kind of "min htlc_max_in_flight as a percentage of channel value" and "min htlc_max_in_filght absolute value" knobs and then calculate it in Channel::get_holder_max_htlc_value_in_flight_msat instead of hard-coding it, but I'm open to ideas.
@TheBlueMatt TheBlueMatt added the good first issue Good for newcomers label Mar 17, 2021
@TheBlueMatt TheBlueMatt mentioned this issue Mar 19, 2021
Merged
jfroche added a commit to jfroche/rust-lightning that referenced this issue Apr 7, 2021
@jfroche
Configure holder max htlc value in flight function of channel value
73089c5 
refs lightningdevkit#850
@jfroche jfroche mentioned this issue Apr 7, 2021
Closed
@TheBlueMatt TheBlueMatt added this to the 0.1.1 milestone Mar 26, 2022
@TheBlueMatt
Copy link
Collaborator Author

Done in #1444.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
0.2
Development

No branches or pull requests
1 participant
@TheBlueMatt