Skip to content

Allow to override config defaults for inbound channels on a per-channel basis #2914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tnull opened this issue Feb 29, 2024 · 4 comments · Fixed by #3596
Closed

Allow to override config defaults for inbound channels on a per-channel basis #2914

tnull opened this issue Feb 29, 2024 · 4 comments · Fixed by #3596
Assignees
Labels
Take a Friday Leave a Friday Stomp the Bugs, Without Much Commitment

Comments

@tnull
Copy link
Contributor

tnull commented Feb 29, 2024

Currently our manual channel acceptance interface doesn't allow us to override any config defaults on a per channel basis, i.e., users can only accept or fail the inbound channel request, not set any specific parameters.

We should allow this.

@tnull tnull self-assigned this Feb 29, 2024
@tnull
Copy link
Contributor Author

tnull commented Feb 29, 2024

Assigning myself for now, hope to pick this up soonish.

@TheBlueMatt
Copy link
Collaborator

I guess we should add a trivial channel config update parameter to the channel acceptance method?

@tnull
Copy link
Contributor Author

tnull commented Nov 26, 2024

I guess we should add a trivial channel config update parameter to the channel acceptance method?

Yeah, that or breaking up the current config object into parts that are static and parts that can be changed by the acceptor at this point. FWIW, some refactoring there could also help users understand who determines what limits, for example.

@tnull tnull removed their assignment Jan 22, 2025
@joostjager joostjager self-assigned this Feb 3, 2025
@joostjager
Copy link
Contributor

Going down the route of adding a config override struct parameter to the accept methods, and from there see if the main config struct can be refactored in a nice way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Take a Friday Leave a Friday Stomp the Bugs, Without Much Commitment
Projects
None yet
3 participants