Skip to content

Fail to apply gossip update for invalid chain hash #2228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tnull opened this issue Apr 25, 2023 · 1 comment · Fixed by #2230
Closed

Fail to apply gossip update for invalid chain hash #2228

tnull opened this issue Apr 25, 2023 · 1 comment · Fixed by #2230
Labels
good first issue Good for newcomers

Comments

@tnull
Copy link
Contributor

tnull commented Apr 25, 2023

Currently, NetworkGraph::update_channel_unsigned and similar methods will happily apply updates, even if they don't match its genesis_hash. This for example happens when syncing a testnet graph with the mainnet RGS url.

However, we should check the given chain hash in NetworkGraph::update_channel_intern and refuse to apply any updates that don't match the network we're on.
@tnull tnull added the good first issue Good for newcomers label Apr 25, 2023
@freddiekrugerrand
Copy link
Contributor

I'd like to pick this up if it's available!

@freddiekrugerrand freddiekrugerrand mentioned this issue Apr 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check chain hash for channel announcement and update freddiekrugerrand/rust-lightning
2 participants
@tnull @freddiekrugerrand