-
Notifications
You must be signed in to change notification settings - Fork 404
Always honor return value in BP process_events_async
#2140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Milestone
Comments
process_events_async
process_events_async
process_events_async
process_events_async
TheBlueMatt
added a commit
to TheBlueMatt/rust-lightning
that referenced
this issue
Apr 3, 2023
If `ChannelManager` is persistable before the async background processor even starts, it may not even get around to overwriting the `should_exit` flag before testing it, and the default value is (incorrectly) true, causing an immediate unconditional exit. The default value should simply be false. Fixes lightningdevkit#2140
TheBlueMatt
added a commit
to TheBlueMatt/rust-lightning
that referenced
this issue
Apr 4, 2023
If `ChannelManager` is persistable before the async background processor even starts, it may not even get around to overwriting the `should_exit` flag before testing it, and the default value is (incorrectly) true, causing an immediate unconditional exit. The default value should simply be false. Fixes lightningdevkit#2140
TheBlueMatt
added a commit
to TheBlueMatt/rust-lightning
that referenced
this issue
Apr 4, 2023
If `ChannelManager` is persistable before the async background processor even starts, it may not even get around to overwriting the `should_exit` flag before testing it, and the default value is (incorrectly) true, causing an immediate unconditional exit. The default value should simply be false. Fixes lightningdevkit#2140
optout21
pushed a commit
to optout21/rust-lightning
that referenced
this issue
Jul 24, 2023
If `ChannelManager` is persistable before the async background processor even starts, it may not even get around to overwriting the `should_exit` flag before testing it, and the default value is (incorrectly) true, causing an immediate unconditional exit. The default value should simply be false. Fixes lightningdevkit#2140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current default for
should_break
istrue
, which is fine, except that we don't override it in the first case of the select, i.e., whenChannelManager::get_persistable_update_future
is already available:rust-lightning/lightning-background-processor/src/lib.rs
Lines 469 to 479 in a9534fe
The text was updated successfully, but these errors were encountered: