Skip to content

Wake background-processor on async monitor update completion #2052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TheBlueMatt opened this issue Feb 25, 2023 · 2 comments · Fixed by #2090
Closed

Wake background-processor on async monitor update completion #2052

TheBlueMatt opened this issue Feb 25, 2023 · 2 comments · Fixed by #2090
Assignees
@TheBlueMatt
Milestone
0.0.115

Comments

@TheBlueMatt
Copy link
Collaborator

Probably need some kinda future like we have for ChannelManager persistence. We should also improve the logging in monitor persistence.
@TheBlueMatt TheBlueMatt added this to the 0.0.115 milestone Feb 25, 2023
@TheBlueMatt TheBlueMatt self-assigned this Feb 25, 2023
@TheBlueMatt
Copy link
Collaborator Author

Note to self, starting point branch with logging: 2023-02-better-chain-monitor-logging

@MaxFangX
Copy link
Contributor

It would be great if this new future is broad enough that the 100ms sleeper future in the LDK background processor could be removed (or at least default to a much higher value, like once a minute). Even though we don't use LDK's background processor directly, it would be a strong signal to us that LDK has confidence in its provided mechanisms for waking the background processor when needed, and would thus give us the confidence to remove our process events timer downstream.

TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Mar 9, 2023
@TheBlueMatt
Wake the background processor if an async monitor update completes
4b8fea8 
If the `ChainMonitor` gets an async monitor update completion, this
means the `ChannelManager` needs to be polled for event processing.
Here we wakt it using the new multi-`Future`-await `Waier`, or the
existing `select` block in the async BP.

Fixes lightningdevkit#2052.
@TheBlueMatt TheBlueMatt mentioned this issue Mar 9, 2023
Merged
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Mar 14, 2023
@TheBlueMatt
Wake the background processor if an async monitor update completes
2584c24 
If the `ChainMonitor` gets an async monitor update completion, this
means the `ChannelManager` needs to be polled for event processing.
Here we wakt it using the new multi-`Future`-await `Waier`, or the
existing `select` block in the async BP.

Fixes lightningdevkit#2052.
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Mar 14, 2023
@TheBlueMatt
Wake the background processor if an async monitor update completes
b2862c6 
If the `ChainMonitor` gets an async monitor update completion, this
means the `ChannelManager` needs to be polled for event processing.
Here we wakt it using the new multi-`Future`-await `Waier`, or the
existing `select` block in the async BP.

Fixes lightningdevkit#2052.
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Mar 15, 2023
@TheBlueMatt
Wake the background processor if an async monitor update completes
bacd4e7 
If the `ChainMonitor` gets an async monitor update completion, this
means the `ChannelManager` needs to be polled for event processing.
Here we wakt it using the new multi-`Future`-await `Waier`, or the
existing `select` block in the async BP.

Fixes lightningdevkit#2052.
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Mar 15, 2023
@TheBlueMatt
Wake the background processor if an async monitor update completes
1cd41c8 
If the `ChainMonitor` gets an async monitor update completion, this
means the `ChannelManager` needs to be polled for event processing.
Here we wakt it using the new multi-`Future`-await `Waier`, or the
existing `select` block in the async BP.

Fixes lightningdevkit#2052.
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Mar 17, 2023
@TheBlueMatt
Wake the background processor if an async monitor update completes
d5ca252 
If the `ChainMonitor` gets an async monitor update completion, this
means the `ChannelManager` needs to be polled for event processing.
Here we wakt it using the new multi-`Future`-await `Waier`, or the
existing `select` block in the async BP.

Fixes lightningdevkit#2052.
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Mar 17, 2023
@TheBlueMatt
Wake the background processor if an async monitor update completes
f0211d5 
If the `ChainMonitor` gets an async monitor update completion, this
means the `ChannelManager` needs to be polled for event processing.
Here we wakt it using the new multi-`Future`-await `Waier`, or the
existing `select` block in the async BP.

Fixes lightningdevkit#2052.
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Mar 20, 2023
@TheBlueMatt
Wake the background processor if an async monitor update completes
382cc04 
If the `ChainMonitor` gets an async monitor update completion, this
means the `ChannelManager` needs to be polled for event processing.
Here we wakt it using the new multi-`Future`-await `Waier`, or the
existing `select` block in the async BP.

Fixes lightningdevkit#2052.
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Mar 21, 2023
@TheBlueMatt
Wake the background processor if an async monitor update completes
a1d138c 
If the `ChainMonitor` gets an async monitor update completion, this
means the `ChannelManager` needs to be polled for event processing.
Here we wakt it using the new multi-`Future`-await `Waier`, or the
existing `select` block in the async BP.

Fixes lightningdevkit#2052.
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Mar 22, 2023
@TheBlueMatt
Wake the background processor if an async monitor update completes
ed2c716 
If the `ChainMonitor` gets an async monitor update completion, this
means the `ChannelManager` needs to be polled for event processing.
Here we wakt it using the new multi-`Future`-await `Waier`, or the
existing `select` block in the async BP.

Fixes lightningdevkit#2052.
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Mar 25, 2023
@TheBlueMatt
Wake the background processor if an async monitor update completes
ecc7d4f 
If the `ChainMonitor` gets an async monitor update completion, this
means the `ChannelManager` needs to be polled for event processing.
Here we wake it using the new multi-`Future`-await `Sleeper`, or
the existing `select` block in the async BP.

Fixes lightningdevkit#2052.
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Mar 25, 2023
@TheBlueMatt
Wake the background processor if an async monitor update completes
212a2a8 
If the `ChainMonitor` gets an async monitor update completion, this
means the `ChannelManager` needs to be polled for event processing.
Here we wake it using the new multi-`Future`-await `Sleeper`, or
the existing `select` block in the async BP.

Fixes lightningdevkit#2052.
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Mar 25, 2023
@TheBlueMatt
Wake the background processor if an async monitor update completes
475b281 
If the `ChainMonitor` gets an async monitor update completion, this
means the `ChannelManager` needs to be polled for event processing.
Here we wake it using the new multi-`Future`-await `Sleeper`, or
the existing `select` block in the async BP.

Fixes lightningdevkit#2052.
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Mar 28, 2023
@TheBlueMatt
Wake the background processor if an async monitor update completes
ef2c7dc 
If the `ChainMonitor` gets an async monitor update completion, this
means the `ChannelManager` needs to be polled for event processing.
Here we wake it using the new multi-`Future`-await `Sleeper`, or
the existing `select` block in the async BP.

Fixes lightningdevkit#2052.
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Mar 28, 2023
@TheBlueMatt
Wake the background processor if an async monitor update completes
f6968d3 
If the `ChainMonitor` gets an async monitor update completion, this
means the `ChannelManager` needs to be polled for event processing.
Here we wake it using the new multi-`Future`-await `Sleeper`, or
the existing `select` block in the async BP.

Fixes lightningdevkit#2052.
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Mar 28, 2023
@TheBlueMatt
Wake the background processor if an async monitor update completes
ba5c184 
If the `ChainMonitor` gets an async monitor update completion, this
means the `ChannelManager` needs to be polled for event processing.
Here we wake it using the new multi-`Future`-await `Sleeper`, or
the existing `select` block in the async BP.

Fixes lightningdevkit#2052.
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Mar 29, 2023
@TheBlueMatt
Wake the background processor if an async monitor update completes
4cfb058 
If the `ChainMonitor` gets an async monitor update completion, this
means the `ChannelManager` needs to be polled for event processing.
Here we wake it using the new multi-`Future`-await `Sleeper`, or
the existing `select` block in the async BP.

Fixes lightningdevkit#2052.
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Mar 30, 2023
@TheBlueMatt
Wake the background processor if an async monitor update completes
3373f42 
If the `ChainMonitor` gets an async monitor update completion, this
means the `ChannelManager` needs to be polled for event processing.
Here we wake it using the new multi-`Future`-await `Sleeper`, or
the existing `select` block in the async BP.

Fixes lightningdevkit#2052.
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Mar 31, 2023
@TheBlueMatt
Wake the background processor if an async monitor update completes
b4658e2 
If the `ChainMonitor` gets an async monitor update completion, this
means the `ChannelManager` needs to be polled for event processing.
Here we wake it using the new multi-`Future`-await `Sleeper`, or
the existing `select` block in the async BP.

Fixes lightningdevkit#2052.
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Mar 31, 2023
@TheBlueMatt
Wake the background processor if an async monitor update completes
72f49e5 
If the `ChainMonitor` gets an async monitor update completion, this
means the `ChannelManager` needs to be polled for event processing.
Here we wake it using the new multi-`Future`-await `Sleeper`, or
the existing `select` block in the async BP.

Fixes lightningdevkit#2052.
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Mar 31, 2023
@TheBlueMatt
Wake the background processor if an async monitor update completes
43003f6 
If the `ChainMonitor` gets an async monitor update completion, this
means the `ChannelManager` needs to be polled for event processing.
Here we wake it using the new multi-`Future`-await `Sleeper`, or
the existing `select` block in the async BP.

Fixes lightningdevkit#2052.
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Apr 3, 2023
@TheBlueMatt
Wake the background processor if an async monitor update completes
6890e43 
If the `ChainMonitor` gets an async monitor update completion, this
means the `ChannelManager` needs to be polled for event processing.
Here we wake it using the new multi-`Future`-await `Sleeper`, or
the existing `select` block in the async BP.

Fixes lightningdevkit#2052.
jbesraa pushed a commit to jbesraa/rust-lightning that referenced this issue Apr 8, 2023
@TheBlueMatt @jbesraa
Wake the background processor if an async monitor update completes
422e2c9 
If the `ChainMonitor` gets an async monitor update completion, this
means the `ChannelManager` needs to be polled for event processing.
Here we wake it using the new multi-`Future`-await `Sleeper`, or
the existing `select` block in the async BP.

Fixes lightningdevkit#2052.
optout21 pushed a commit to optout21/rust-lightning that referenced this issue Jul 24, 2023
@TheBlueMatt @optout21
Wake the background processor if an async monitor update completes
5106b22 
If the `ChainMonitor` gets an async monitor update completion, this
means the `ChannelManager` needs to be polled for event processing.
Here we wake it using the new multi-`Future`-await `Sleeper`, or
the existing `select` block in the async BP.

Fixes lightningdevkit#2052.
@MaxFangX MaxFangX mentioned this issue Mar 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheBlueMatt TheBlueMatt

Labels
None yet
Projects
None yet
Milestone
0.0.115
Development

Successfully merging a pull request may close this issue.

Wake background-processor on async monitor update completion TheBlueMatt/rust-lightning
2 participants
@TheBlueMatt @MaxFangX