Skip to content

Refuse new ChannelMonitor Updates after funding-spend-confirmed #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TheBlueMatt opened this issue Dec 19, 2022 · 2 comments
Closed

Refuse new ChannelMonitor Updates after funding-spend-confirmed #1925

TheBlueMatt opened this issue Dec 19, 2022 · 2 comments
Milestone
0.0.114

Comments

@TheBlueMatt
Copy link
Collaborator

Came up at #1922 (comment) - I think we should do this - once funding is spent we shouldn't be generating updates.
@TheBlueMatt TheBlueMatt added this to the 0.0.114 milestone Dec 19, 2022
@wpaulino
Copy link
Contributor

Isn't this already handled?

rust-lightning/lightning/src/chain/channelmonitor.rs

Line 2380 in e38ab09

if ret.is_ok() && self.funding_spend_seen {

@TheBlueMatt
Copy link
Collaborator Author

Ah, indeed, yea, that's a better solution to it too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.0.114
Development

No branches or pull requests
2 participants
@TheBlueMatt @wpaulino