Skip to content

RGS Accepts Stale Data Without Error #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TheBlueMatt opened this issue Oct 19, 2022 · 0 comments · Fixed by #1921
Closed

RGS Accepts Stale Data Without Error #1785

TheBlueMatt opened this issue Oct 19, 2022 · 0 comments · Fixed by #1921
Milestone
0.1

Comments

@TheBlueMatt
Copy link
Collaborator

As of #1764, the RGS processor will now happily accept data that is >2 weeks old, which is an indication the server is busted and we should actually generate an error, see #1764 (comment). A straight partial-revert of 1764 is probably not the right solution - the errors are just not descriptive enough for us and we should fix that.
@TheBlueMatt TheBlueMatt added good first issue Good for newcomers and removed good first issue Good for newcomers labels Oct 19, 2022
@G8XSU G8XSU mentioned this issue Oct 19, 2022
Merged
@TheBlueMatt TheBlueMatt added this to the 0.1 milestone Oct 29, 2022
arik-so added a commit to arik-so/rust-lightning that referenced this issue Dec 16, 2022
@arik-so
WIP: Throw error for RGS data that's more than two weeks old, fixing l…
630e041 
…ightningdevkit#1785
@arik-so arik-so mentioned this issue Dec 16, 2022
Merged
arik-so added a commit to arik-so/rust-lightning that referenced this issue Dec 16, 2022
@arik-so
WIP: Throw error for RGS data that's more than two weeks old, fixing l…
9550a6f 
…ightningdevkit#1785
arik-so added a commit to arik-so/rust-lightning that referenced this issue Feb 9, 2023
@arik-so
WIP: Throw error for RGS data that's more than two weeks old, fixing l…
d36e64a 
…ightningdevkit#1785
arik-so added a commit to arik-so/rust-lightning that referenced this issue Feb 9, 2023
@arik-so
Throw error for RGS data that's more than two weeks old, fixing light…
7fd91af 
…ningdevkit#1785
arik-so added a commit to arik-so/rust-lightning that referenced this issue Feb 16, 2023
@arik-so
Throw error for RGS data that's more than two weeks old, fixing light…
f74ead9 
…ningdevkit#1785
arik-so added a commit to arik-so/rust-lightning that referenced this issue Feb 16, 2023
@arik-so
Throw error for RGS data that's more than two weeks old, fixing light…
2f36c92 
…ningdevkit#1785
optout21 pushed a commit to optout21/rust-lightning that referenced this issue Jul 24, 2023
@arik-so @optout21
Throw error for RGS data that's more than two weeks old, fixing light…
debf2dc 
…ningdevkit#1785
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1
Development

Successfully merging a pull request may close this issue.

Throw error for RGS data that's more than two weeks old arik-so/rust-lightning
1 participant
@TheBlueMatt