Check that the HRPs generated in BOLT 11 RawHrp are always valid

TheBlueMatt · TheBlueMatt · commit c5658f6cc2cf · 2024-10-03T17:24:59.000Z
...in `debug_assertions`.
diff --git a/lightning-invoice/src/lib.rs b/lightning-invoice/src/lib.rs
@@ -313,6 +313,7 @@ impl RawHrp {
 	pub fn to_hrp(&self) -> bech32::Hrp {
 		let hrp_str = self.to_string();
 		let s = core::str::from_utf8(&hrp_str.as_bytes()).expect("HRP bytes should be ASCII");
+		debug_assert!(bech32::Hrp::parse(s).is_ok(), "We should always build BIP 173-valid HRPs");
 		bech32::Hrp::parse_unchecked(s)
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -313,6 +313,7 @@ impl RawHrp {`
`313`	`313`	`pub fn to_hrp(&self) -> bech32::Hrp {`
`314`	`314`	`let hrp_str = self.to_string();`
`315`	`315`	`let s = core::str::from_utf8(&hrp_str.as_bytes()).expect("HRP bytes should be ASCII");`
	`316`	`+ debug_assert!(bech32::Hrp::parse(s).is_ok(), "We should always build BIP 173-valid HRPs");`
`316`	`317`	`bech32::Hrp::parse_unchecked(s)`
`317`	`318`	`}`
`318`	`319`	`}`