Skip to content

Commit 8ca6cb7

Browse files
committed
Add missing known features in constructor
PaymentSecret and BasicMPP were added in d39f258 but were not accounted for in with_known_relevant_init_flags.
1 parent fe73761 commit 8ca6cb7

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

lightning/src/ln/features.rs

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -165,9 +165,10 @@ impl NodeFeatures {
165165
match i {
166166
// Blank out initial_routing_sync (feature bits 2/3), gossip_queries (6/7),
167167
// gossip_queries_ex (10/11), option_static_remotekey (12/13), and
168-
// payment_secret (14/15)
168+
// option_support_large_channel (16/17)
169169
0 => flags.push(feature_byte & 0b00110011),
170-
1 => flags.push(feature_byte & 0b00000011),
170+
1 => flags.push(feature_byte & 0b11000011),
171+
2 => flags.push(feature_byte & 0b00000011),
171172
_ => (),
172173
}
173174
}
@@ -388,10 +389,12 @@ mod tests {
388389

389390
{
390391
// Check that the flags are as expected: optional_data_loss_protect,
391-
// option_upfront_shutdown_script, and var_onion_optin set.
392+
// option_upfront_shutdown_script, var_onion_optin, payment_secret, and
393+
// basic_mpp.
394+
assert_eq!(res.flags.len(), 3);
392395
assert_eq!(res.flags[0], 0b00100010);
393-
assert_eq!(res.flags[1], 0b00000010);
394-
assert_eq!(res.flags.len(), 2);
396+
assert_eq!(res.flags[1], 0b10000010);
397+
assert_eq!(res.flags[2], 0b00000010);
395398
}
396399

397400
// Check that the initial_routing_sync feature was correctly blanked out.

0 commit comments

Comments
 (0)