Upgrade LDK Node #45
Upgrade LDK Node #45
Conversation
|
Is this meant to include all the commits from #44? Because it seems to be doing much more than just increasing the LDK Node version. |
|
@arik-so It doesn't include PR-44 commits, these are just the interface changes required to upgrade ldk/ldk-node. |
G8XSU
force-pushed
the
ldk-node-upgrade-for-log
branch
2 times, most recently
from
0c26c06 to
8f64073
Compare
|
Looks fine to me, just adding some context to some of the commits might be a good idea. |
LDK Node MSRV has changed to 1.75.0, hence we update our MSRV as well.
In PaymentForwarded events, we now have access to prev_node_id and next_node_id.
In PaymentForwarded events, we now have access to prev_node_id and next_node_id.
Since they are not required for existing logging.
Bolt11 Send API now supports setting description_hash instead of description, account for this api change in ldk.
Onchain sends now support setting a custom fee-rate, account for this api change in ldk.
LDK Node now supports logging through log facade and there are minor associated api changes.
G8XSU
force-pushed
the
ldk-node-upgrade-for-log
branch
from
8f64073 to
b887021
Compare
|
Added. |
| // The on-chain transaction is confirmed in the best chain. | ||
| message Confirmed { | ||
| // The hash of the block in which the transaction was confirmed. | ||
| string block_hash = 1; |
There was a problem hiding this comment.
should this be a string? If so, should we point out it's hex, and whether it's big endian? Because bitcoind can make that a pain with their little endian shenanigans
There was a problem hiding this comment.
Yes, it should be a string, reasoning: #14
IIUC, hex representation itself isn't endian specific,
since hashes are just sequence of bytes, we directly use the hex representation. (and no endianess involved in seq of bytes.)
it could be called "big-endian" but will mention it only as hex representation.
clarified to indicate hex representation.
Onchain payments now provide additional information such as transaction_id and confirmation_status.
G8XSU
force-pushed
the
ldk-node-upgrade-for-log
branch
from
b887021 to
50f9f6b
Compare
Upgrade LDK Node to commit [6de350040e0fc5eb9cfcd15fad3919f5a79b82b9]