Add ChannelPending event
#60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurvis
reviewed
Apr 4, 2023
tnull
force-pushed
the
2023-04-add-channel-pending-event
branch
from
454ebf2 to
2185397
Compare
|
Rebased on main after #13 has been merged. |
tnull
force-pushed
the
2023-04-add-channel-pending-event
branch
from
2185397 to
126e56a
Compare
|
Rebased on #64. |
jkczyz
previously approved these changes
Apr 20, 2023
| /// The `user_channel_id` of the channel. | ||
| user_channel_id: u128, | ||
| /// The `temporary_channel_id` this channel used to be known by during channel establishment. | ||
| former_temporary_channel_id: [u8; 32], |
There was a problem hiding this comment.
nit: Would opt to drop former as this seems to be implied by "temporary", FWIW.
There was a problem hiding this comment.
I tend to disagree. The 'former' is there to clearly communicate that it's invalid by now.
tnull
force-pushed
the
2023-04-add-channel-pending-event
branch
from
126e56a to
4d7e940
Compare
|
Rebased after merging #64. |
jkczyz
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #64 now.
After lightningdevkit/rust-lightning#2098 has been merged, we add the new
ChannelPendingevent which notifies users of newly created channels that are pending confirmation on-chain.