-
Notifications
You must be signed in to change notification settings - Fork 102
Add Gradle and GitHub Actions tooling to package for Maven Central #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tnull
merged 7 commits into
lightningdevkit:main
from
jurvis:jurvis/to-upstream/maven-publish
May 26, 2023
Merged
Add Gradle and GitHub Actions tooling to package for Maven Central #59
tnull
merged 7 commits into
lightningdevkit:main
from
jurvis:jurvis/to-upstream/maven-publish
May 26, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
c54d4d5
to
fb391ef
Compare
fb391ef
to
3f6bbe2
Compare
rebased to 3f6bbe2 |
tnull
approved these changes
May 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank a lot for this!
As discussed offline I'll go ahead and merge this as-is and will address any feedback and open TODOs in a follow-up.
orbitalturtle
pushed a commit
to orbitalturtle/ldk-node
that referenced
this pull request
Jun 14, 2023
…ightningdevkit#59) * Maven publishing for ldk-node-android * GHA to publish ldk-node-android to Maven Central * Maven Publish for ldk-node-jvm * GHA action to publish ldk-node-jvm * Copy .so file if building with Linux host * Point everything upstream * Set Android libraryVersion to 0.0.1-SNAPSHOT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #25.
Moved from tnull#4.
Tested and working for...
Based on work done by BDK team.
Things left to do
Release Workflow
bindings/kotlin/ldk-node-android/gradle.properties
andbindings/kotlin/ldk-node-jvm/gradle.properties
. Suffix with-SNAPSHOT
to publish to snapshot repository for testing.