Skip to content

Add Gradle and GitHub Actions tooling to package for Maven Central #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 26, 2023

Conversation

jurvis
Copy link
Contributor

@jurvis jurvis commented Apr 4, 2023

Based on #25.

Moved from tnull#4.

Tested and working for...

Based on work done by BDK team.

Things left to do

  • Adding Nexus OSSRH username/password to GitHub Actions
  • Adding PGP Key ID, Secret Key, and Passphrase to GitHub Actions

Release Workflow

  1. Make commit with changes to version in bindings/kotlin/ldk-node-android/gradle.properties and bindings/kotlin/ldk-node-jvm/gradle.properties. Suffix with -SNAPSHOT to publish to snapshot repository for testing.
  2. Manually run GitHub action for publishing

@tnull tnull mentioned this pull request Apr 4, 2023
47 tasks
@tnull tnull added this to the 0.1 milestone Apr 25, 2023
@jurvis jurvis force-pushed the jurvis/to-upstream/maven-publish branch from c54d4d5 to fb391ef Compare April 26, 2023 18:02
@jurvis jurvis force-pushed the jurvis/to-upstream/maven-publish branch from fb391ef to 3f6bbe2 Compare May 10, 2023 04:23
@jurvis
Copy link
Contributor Author

jurvis commented May 10, 2023

rebased to 3f6bbe2

@tnull tnull self-requested a review May 19, 2023 11:19
Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank a lot for this!

As discussed offline I'll go ahead and merge this as-is and will address any feedback and open TODOs in a follow-up.

@tnull tnull merged commit 423e414 into lightningdevkit:main May 26, 2023
orbitalturtle pushed a commit to orbitalturtle/ldk-node that referenced this pull request Jun 14, 2023
…ightningdevkit#59)

* Maven publishing for ldk-node-android

* GHA to publish ldk-node-android to Maven Central

* Maven Publish for ldk-node-jvm

* GHA action to publish ldk-node-jvm

* Copy .so file if building with Linux host

* Point everything upstream

* Set Android libraryVersion to 0.0.1-SNAPSHOT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants