Expose Network as enum type rather than via string

Author: tnull

bindings/kotlin/ldk-node-jvm/lib/src/test/kotlin/org/lightningdevkit/ldknode/LibraryTest.kt

@@ -61,8 +61,7 @@ class LibraryTest {
     @Test fun fullCycle() {
         setup()
 
-        val network: Network = "regtest"
-        assertEquals(network, "regtest")
+        val network = Network.REGTEST
 
         val tmpDir1 = createTempDirectory("ldk_node").toString()
         println("Random dir 1: $tmpDir1")

bindings/ldk_node.udl

@@ -121,6 +121,13 @@ enum PaymentStatus {
 	"Failed",
 };
 
+enum Network {
+	"Bitcoin",
+	"Testnet",
+	"Signet",
+	"Regtest",
+};
+
 dictionary PaymentDetails {
 	PaymentHash hash;
 	PaymentPreimage? preimage;
@@ -190,8 +197,5 @@ typedef string ChannelId;
 [Custom]
 typedef string UserChannelId;
 
-[Custom]
-typedef string Network;
-
 [Custom]
 typedef string Mnemonic;

src/types.rs

@@ -22,7 +22,7 @@ use lightning_transaction_sync::EsploraSyncClient;
 use bitcoin::hashes::sha256::Hash as Sha256;
 use bitcoin::hashes::Hash;
 use bitcoin::secp256k1::PublicKey;
-use bitcoin::{Address, Network, OutPoint, Txid};
+use bitcoin::{Address, OutPoint, Txid};
 
 use bip39::Mnemonic;
 
@@ -285,18 +285,6 @@ impl Readable for UserChannelId {
 	}
 }
 
-impl UniffiCustomTypeConverter for Network {
-	type Builtin = String;
-
-	fn into_custom(val: Self::Builtin) -> uniffi::Result<Self> {
-		Ok(Network::from_str(&val).map_err(|_| Error::InvalidNetwork)?)
-	}
-
-	fn from_custom(obj: Self) -> Self::Builtin {
-		obj.to_string()
-	}
-}
-
 impl UniffiCustomTypeConverter for Txid {
 	type Builtin = String;
 	fn into_custom(val: Self::Builtin) -> uniffi::Result<Self> {