-
Notifications
You must be signed in to change notification settings - Fork 51
Podcasting 2.0 blip #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀🚀🚀 |
Hi @satoshisstream, thanks so much for documenting! Some initial housekeeping, could you please:
|
Thanks! How about that? :) |
Thank you @t-bast . I believe I have addressed all your good comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to write this up!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I haven't verified the test vector myself though.
There is something that is still unclear to me, related to this comment: #10 (comment)
If you want this to work without being directly connected to the person you pay, your TLV shouldn't be in the update_add_htlc
namespace, it should be in the payment_onion_payload
namespace (for which you should create a new section in blip 2)?
Do note that this heavily restricts the amount of data available, as onions have a small fixed size.
Added the |
Thanks, that looks good enough. Unfortunately we don't have a great way to reference the onion used inside Looks good to me now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Thanks Lucas from LL helping drafting the blip
Based on the TLV registry: https://github.com/satoshisstream/satoshis.stream/blob/main/TLV_registry.md please find a formalized blip in this PR.
Let me know if I need to do something!