Skip to content

Podcasting 2.0 blip #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 27, 2022
Merged

Conversation

satoshisstream
Copy link
Contributor

Thanks Lucas from LL helping drafting the blip

Based on the TLV registry: https://github.com/satoshisstream/satoshis.stream/blob/main/TLV_registry.md please find a formalized blip in this PR.

Let me know if I need to do something!

@lucasdcf
Copy link

🚀🚀🚀

@ryanthegentry
Copy link
Collaborator

ryanthegentry commented Jan 25, 2022

Hi @satoshisstream, thanks so much for documenting! Some initial housekeeping, could you please:

  1. rename the doc to blip-0010, given Github's numbering convention
  2. include in this PR an update to blip-0002 "registering" TLV type 7629169 with name Boostagram (?) and a link to the future blip-0010. I assume this is an update_add_htlc message like keysend, so can follow that PR as an example if you'd like.
  3. include in this PR an update to the README adding blip-010 (again following the keysend bLIP as an example).

@satoshisstream
Copy link
Contributor Author

Thanks!

How about that? :)

@satoshisstream
Copy link
Contributor Author

Thank you @t-bast . I believe I have addressed all your good comments.

Copy link
Contributor

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to write this up!

Copy link
Contributor

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I haven't verified the test vector myself though.

There is something that is still unclear to me, related to this comment: #10 (comment)

If you want this to work without being directly connected to the person you pay, your TLV shouldn't be in the update_add_htlc namespace, it should be in the payment_onion_payload namespace (for which you should create a new section in blip 2)?

Do note that this heavily restricts the amount of data available, as onions have a small fixed size.

@satoshisstream
Copy link
Contributor Author

Added the payment_onion_payload part. For blip2 I just follow what you say, the chapters are a bit unclear to me. Hope I did it correctly ;)

@t-bast
Copy link
Contributor

t-bast commented Jan 27, 2022

Added the payment_onion_payload part. For blip2 I just follow what you say, the chapters are a bit unclear to me. Hope I did it correctly ;)

Thanks, that looks good enough.

Unfortunately we don't have a great way to reference the onion used inside update_add_htlc (the bolts don't explicitly name it) but I think it should be easy enough to understand for readers (we do want to distinguish onions used in update_add_htlc from onions used in onion messages as they don't use the same tlvs).

Looks good to me now 👍

Copy link
Collaborator

@ryanthegentry ryanthegentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ryanthegentry ryanthegentry merged commit acfd566 into lightning:master Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants