fix possible infinite loop when line is undefined (#635)

wouterlucas · web-flow · commit 25a597560f16 · 2025-09-11T11:56:12.000Z
diff --git a/src/core/text-rendering/sdf/Utils.ts b/src/core/text-rendering/sdf/Utils.ts
@@ -36,13 +36,13 @@ export const measureLines = (
 
   while (remainingLines > 0) {
     const line = lines[i];
+    i++;
+    remainingLines--;
     if (line === undefined) {
       continue;
     }
     const width = measureText(line, fontFamily, designLetterSpacing);
     measuredLines.push([line, width]);
-    i++;
-    remainingLines--;
   }
 
   return [

Original file line number	Diff line number	Diff line change
`@@ -36,13 +36,13 @@ export const measureLines = (`
`36`	`36`
`37`	`37`	`while (remainingLines > 0) {`
`38`	`38`	`const line = lines[i];`
	`39`	`+ i++;`
	`40`	`+ remainingLines--;`
`39`	`41`	`if (line === undefined) {`
`40`	`42`	`continue;`
`41`	`43`	`}`
`42`	`44`	`const width = measureText(line, fontFamily, designLetterSpacing);`
`43`	`45`	`measuredLines.push([line, width]);`
`44`		`- i++;`
`45`		`- remainingLines--;`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`return [`