Skip to content

Add MiMa CLI #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add MiMa CLI #823

wants to merge 3 commits into from

Conversation

kubukoz
Copy link

@kubukoz kubukoz commented Sep 2, 2024

See #701.

Early state, probably should get at least a README. The code is pretty much a verbatim copy of https://github.com/jeremyrsmith/mima-cli/ (licensed under Apache 2.0, I'm not sure what the preferred protocol is for adding a notice here).

@kubukoz
Copy link
Author

kubukoz commented Apr 14, 2025

@SethTisue can we revive this? Hate to see this go to waste :)

@SethTisue
Copy link
Collaborator

sure. let's see if CI likes it

val newBin = newBinOpt.getOrElse(
throw new IllegalArgumentException("New binary was not specified")
)
// TODO: should have some machine-readable output here, as an option
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can probably be left for later, if anyone needs it

@SethTisue
Copy link
Collaborator

CI likes it. Is it ready for review? (I agree that a readme addition is needed.)

@kubukoz
Copy link
Author

kubukoz commented Apr 28, 2025

Hi, sorry, it's been a busy couple weeks (as usual), I'll try to bring it up to reviewable this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants