Description
See discussion over on this PR and in Slack (private link).
Basically, we need to patch jquery-form and forking a copy into our monorepo seems the least horrible way to do it. Other options considered:
- Original PR to Brian just patched the code inline in liferay-portal but was rejected.
- Draft PR from me checking in a patch and applying it via Gradle; all too fiddly.
- Doing a literal GitHub fork, or a "fork-plus-more-stuff" in a separate repo (like we have been doing in liferay-ckeditor); rejected because we don't like the diaspora affect of having yet another scattered repo.
- Patching a JAR using the Gradle
PatchTask; rejected because shipping npm packages via JARs seems, er, "suboptimal".
So, basic plan is to dump a copy into the repo here undo a "third-party" directory. ie. We won't apply the usual linting/formatting/testing; these projects will live off in their own separate world, even more isolated than the stuff in the maintenance/ directory (which at least uses shared linting/formatting etc), and it will be for stuff that we don't intend to update much... If that changes for any project, and we realize we need to update a project more invasively or frequently, we have the option of turning it into a "real" project and opting in to linting/formatting/testing etc. At that point it really becomes a hard fork. We can cross that bridge when we come to it.