Skip to content

Emscripten's key events should attempt to use the 'code' property. #2098

Closed
@SDLBugzilla

Description

@SDLBugzilla

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: HG 2.1
Reported for operating system, platform: All, Other

Comments on the original bug report:

On 2016-02-15 18:42:09 +0000, Tanner Rogalsky wrote:

On the emscripten platform, Emscripten_HandleKey in SDL_emscriptenevents.c maps key codes directly to scancodes which results in scancodes never differing from keycodes.

HandleKey should attempt to use the code property on the EmscriptenKeyboardEvent object first, if it exists, to get the correct scan code.

On 2020-01-01 14:26:47 +0000, Emil Lenngren wrote:

Yes, please implement this. I have a game which uses SDL scancodes to work properly regardless of keyboard layout, but noticed that it doesn't work correctly when compiling for the emscripten target when I have a Dvorak keyboard.

On 2020-07-14 10:45:16 +0000, Charlie Birks wrote:

There's currently an unmerged downstream patch for this: emscripten-ports/SDL2#117

On 2020-07-15 22:48:51 +0000, Sam Lantinga wrote:

The patch doesn't cleanly apply, but conceptually seems good.

Ryan, can you review for 2.0.14?

On 2020-07-16 17:02:54 +0000, Ryan C. Gordon wrote:

Let's get this into 2.0.16, but I don't want to apply it to the almost-done 2.0.14.

--ryan.

On 2020-07-16 17:16:48 +0000, Charlie Birks wrote:

Created attachment 4418
Updated patch

Fixed the patch, not too sure about the KaiOS bits.

On 2020-07-16 17:35:06 +0000, Charlie Birks wrote:

This does break support for (old) browsers that don't support .code. I don't know if that's actually a problem for anyone...

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions