Skip to content

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Jan 7, 2020

No description provided.

@alanshaw alanshaw requested a review from jacobheun January 7, 2020 14:37
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I went ahead and added a test to avoid future regressions.

@jacobheun jacobheun merged commit c44e6e3 into refactor/async-await Jan 7, 2020
@jacobheun jacobheun deleted the fix/stop-discoveries branch January 7, 2020 15:27
jacobheun added a commit that referenced this pull request Jan 24, 2020
* fix: stop discoveries

* test: add discovery stop test

* chore: fix lint

Co-authored-by: Jacob Heun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants