Skip to content

Conversation

jacobheun
Copy link
Contributor

  • Adds libp2p.connections getter to allow users to more easily get existing connections.
  • Fixes libp2p.hangUp(peer) to take arguments that the API doc specifies.

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just found a small typo

Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobheun jacobheun merged commit 6ca19c5 into refactor/async-await Dec 16, 2019
@jacobheun jacobheun deleted the fix/connections-hangup branch December 16, 2019 18:24
jacobheun added a commit that referenced this pull request Jan 24, 2020
* fix: make hangup accept what the API says it does

* feat: add libp2p.connections getter

* chore: fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants