-
Notifications
You must be signed in to change notification settings - Fork 506
fix: add local definition of isPrivateIp #2362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
maschad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should verify that this decreases the bundle size and update the limits as well for each package so that this change is worthwhile.
| @@ -0,0 +1,203 @@ | |||
| /* eslint-env mocha */ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a copy of https://github.com/frenchbread/private-ip/blob/master/test.js ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, also the source is a modified version of https://github.com/frenchbread/private-ip/blob/master/src/index.ts
Its guaranteed to be smaller because its the same code, but with two fewer dependencies. |
|
@wemeetagain LGTM but CI is failing, could you take a look please? |
|
@achingbrain ready for re-review |
Description
Use local defintion of isPrivateIp instead of
private-ippackageThis should reduce bundle size and remove another commonjs sub-dependency (
ipaddr.js)Change checklist