Skip to content

fix: make mss check logger before use #2261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 29, 2023
Merged

fix: make mss check logger before use #2261

merged 4 commits into from
Nov 29, 2023

Conversation

@achingbrain
Copy link
Member

@achingbrain achingbrain commented Nov 29, 2023

Check logger is present before use. This should have gone out as a breaking change.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
fix: make mss check logger before use
2e7751e 
This should have gone out as a breaking change.
@achingbrain achingbrain requested a review from a team as a code owner November 29, 2023 12:27
@achingbrain achingbrain merged commit f19fd1c into main Nov 29, 2023
@achingbrain achingbrain deleted the fix/multistream-select-log branch November 29, 2023 14:18
achingbrain added a commit that referenced this pull request Nov 29, 2023
@achingbrain
fix: make mss check logger before use (#2261)
b90c102 
Check logger is present before use. This should have gone out as a breaking change.
achingbrain added a commit that referenced this pull request Nov 29, 2023
@achingbrain
fix: make mss check logger before use (#2261)
d1ee2f0 
Check logger is present before use. This should have gone out as a breaking change.
achingbrain added a commit that referenced this pull request Nov 29, 2023
@achingbrain
fix: make mss check logger before use (#2261)
6e7e782 
Check logger is present before use. This should have gone out as a breaking change.
achingbrain added a commit that referenced this pull request Nov 29, 2023
@achingbrain
fix: make mss check logger before use (#2261)
8a267b0 
Check logger is present before use. This should have gone out as a breaking change.
achingbrain added a commit that referenced this pull request Nov 29, 2023
@achingbrain
fix: make mss check logger before use (#2261)
b29a8ce 
Check logger is present before use. This should have gone out as a breaking change.
achingbrain added a commit that referenced this pull request Nov 29, 2023
@achingbrain
fix: make mss check logger before use (#2261)
ffb6614 
Check logger is present before use. This should have gone out as a breaking change.
achingbrain added a commit that referenced this pull request Nov 29, 2023
@achingbrain
fix: make mss check logger before use (#2261)
c5f4f42 
Check logger is present before use. This should have gone out as a breaking change.
achingbrain added a commit that referenced this pull request Nov 29, 2023
@achingbrain
fix: make mss check logger before use (#2261)
b32c738 
Check logger is present before use. This should have gone out as a breaking change.
achingbrain added a commit that referenced this pull request Nov 29, 2023
@achingbrain
fix: make mss check logger before use (#2261)
3fa4bb2 
Check logger is present before use. This should have gone out as a breaking change.
achingbrain added a commit that referenced this pull request Nov 29, 2023
@achingbrain
fix: make mss check logger before use (#2261)
33ba221 
Check logger is present before use. This should have gone out as a breaking change.
achingbrain added a commit that referenced this pull request Nov 29, 2023
@achingbrain
fix: make mss check logger before use (#2261)
b17670d 
Check logger is present before use. This should have gone out as a breaking change.
achingbrain added a commit that referenced this pull request Nov 29, 2023
@achingbrain
fix: make mss check logger before use (#2261)
551622a 
Check logger is present before use. This should have gone out as a breaking change.
@achingbrain achingbrain mentioned this pull request Nov 30, 2023
Closed
achingbrain added a commit that referenced this pull request Nov 30, 2023
@achingbrain
fix: make mss check logger before use (#2261)
ef0b052 
Check logger is present before use. This should have gone out as a breaking change.
achingbrain added a commit that referenced this pull request Nov 30, 2023
@achingbrain
fix: make mss check logger before use (#2261)
664d2f6 
Check logger is present before use. This should have gone out as a breaking change.
achingbrain added a commit that referenced this pull request Nov 30, 2023
@achingbrain
fix: make mss check logger before use (#2261)
b32a8b6 
Check logger is present before use. This should have gone out as a breaking change.
achingbrain added a commit that referenced this pull request Dec 1, 2023
@achingbrain
fix: make mss check logger before use (#2261) (#2274)
cf96369 
Check logger is present before use. Fixes a regression introduced during the 1.0 release where mss didn't go out as a major - reintroduces backwards compatibility.
This was referenced Dec 1, 2023
Closed
Merged
This was referenced Jan 18, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@achingbrain