refactor!: extract ping service into separate module #2218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
force-pushed
the
release-v1.0
branch
from
9a15061 to
e99f66b
Compare
BREAKING CHANGE: imports from `libp2p/ping` must be updated to `@libp2p/ping`
achingbrain
force-pushed
the
refactor/extract-ping-service
branch
from
693bbaf to
9637cc4
Compare
wemeetagain
reviewed
Nov 8, 2023
| @@ -0,0 +1,65 @@ | |||
| { | |||
| "name": "@libp2p/ping", | |||
| "version": "0.0.0", | |||
There was a problem hiding this comment.
This is a breaking change in this module so publishing will give us v1
achingbrain
added a commit
that referenced
this pull request
Nov 10, 2023
BREAKING CHANGE: imports from `libp2p/ping` must be updated to `@libp2p/ping`
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Nov 10, 2023
BREAKING CHANGE: imports from `libp2p/ping` must be updated to `@libp2p/ping`
achingbrain
added a commit
that referenced
this pull request
Nov 15, 2023
BREAKING CHANGE: imports from `libp2p/ping` must be updated to `@libp2p/ping`
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: imports from
libp2p/pingmust be updated to@libp2p/pingChange checklist