fix: delay notification of early WebRTC stream creation #2206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The datachannel muxer is created during set up of the `Connection` object. If we notify of early stream connection before the `Connection` object is properly configured, the early streams will be lost. The fix is to notify asynchronously which gives the upgrader enough time to finish setting up the `Connection`.
achingbrain
changed the title
maschad
approved these changes
Nov 6, 2023
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The datachannel muxer is created during set up of the
Connectionobject. If we notify of early stream creation before theConnectionobject is properly configured, the early streams will be lost.This can happen when the remote opens a data channel before the local node has finished setting up it's end of the connection.
The fix is to notify asynchronously which gives the upgrader enough time to finish setting up the
Connection.Change checklist