Skip to content

fix: datachannel label should be an empty string #2204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2023
Merged

fix: datachannel label should be an empty string #2204

merged 1 commit into from
Nov 6, 2023

Conversation

@achingbrain
Copy link
Member

@achingbrain achingbrain commented Nov 6, 2023

Fixes regession introduced by #2200

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain achingbrain requested a review from a team as a code owner November 6, 2023 13:53
@achingbrain achingbrain merged commit dfbe0cc into master Nov 6, 2023
@achingbrain achingbrain deleted the fix/leave-datachannel-label-empty branch November 6, 2023 14:48
This was referenced Jan 18, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@achingbrain