This repository was archived by the owner on Oct 3, 2023. It is now read-only.
fix: discover peers faster #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we had to wait 10s (by default) **before** initial peer discovery, since the module uses an interval to re-emit discovered peers every 10s. This PR refactors `start` to do an initial discovery of the boostrap peers immediately after it has started (i.e. after the callback has been called). This addresses the problem where a call to `cat`/`get`/others immediately after the IPFS `ready` event would take at minimum 10s to get content stored on the preload nodes due to the initial delay in discovery. fixes #85 resolves ipfs/js-ipfs#1706 License: MIT Signed-off-by: Alan Shaw <[email protected]>
ghost
assigned 
|
@alanshaw released |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had to wait 10s (by default) before initial peer discovery, since the module uses an interval to re-emit discovered peers every 10s. This PR refactors
startto do an initial discovery of the boostrap peers immediately after it has started (i.e. after the callback has been called).This addresses the problem where a call to
cat/get/others immediately after the IPFSreadyevent would take at minimum 10s to get content stored on the preload nodes due to the initial delay in discovery.fixes #85
resolves ipfs/js-ipfs#1706