Fix resources path computation in test setup #1630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The resources path is set based on the path of the current assembly. The problem is that the assembly directory has a different number of components, depending on whether the Configuration environment variable is set or not. Therefore, the previous code, that depended on the number of subdirs, would fail if there is no value for the Configuration environment variable. The new code looks for the occurrence of a well-known string in the path and bases the path of the test resources off that position. It is still pretty sub-optimal, but I think it's a bit less sub-optimal than it was. Tested in the following ways: - run dotnet test on one test from the command line on Windows; - click on "Run Test" from Visual Studio Code. Fixes libgit2#1629.
|
As you noted, this is imperfect - we might want to consider copying the entire Anyway, I'm not in love with this but this is a strict improvement over what's there now, which I'm surprised ever worked. :D Thanks for this! |
This was referenced Nov 2, 2018
alex-weaver
pushed a commit
to alex-weaver/libgit2sharp
that referenced
this pull request
Mar 23, 2023
Fix resources path computation in test setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resources path is set based on the path of the current assembly.
The problem is that the assembly directory has a different number of
components, depending on whether the Configuration environment variable
is set or not.
Therefore, the previous code, that depended on the number of subdirs,
would fail if there is no value for the Configuration environment
variable.
The new code looks for the occurrence of a well-known string in the path
and bases the path of the test resources off that position.
It is still pretty sub-optimal, but I think it's a bit less sub-optimal
than it was.
Tested in the following ways:
Fixes #1629.