Skip to content

Wireup http custom headers in fetch options #1542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2018
Merged

Wireup http custom headers in fetch options #1542

merged 1 commit into from
Oct 4, 2018

Conversation

ramshenai
Copy link
Contributor

Summary

  • Expose custom headers for GitFetchOptions for Fetch, and indirectly for CloneOptions
  • Had to wrap these custom headers with GitFetchOptionsWrapper to dispose them. (Similar to how GitCheckoutOptsWrapper)

Tests

  • Unit-tests, Added coverage in CloneFixture .& FetchFixture. the malformed/reserved headers are handled by libgit2, so you can validate them getting passed through to libgit2.
  • Manual verification, tested against git-server

@ethomson
Copy link
Member

Awesome, thanks for contributing this! I'm a little busy this weekend, but I'll try to take a look at this soon. Thanks!

@ramshenai
Copy link
Contributor Author

Hello @ethomson, I was wondering if you had a chance to take a look?

Thanks!

@64bits
Copy link

64bits commented Apr 25, 2018

I'd like to use custom authorization headers, need this PR to get merged!

@ethomson ethomson merged commit e419ea8 into libgit2:master Oct 4, 2018
@ethomson
Copy link
Member

ethomson commented Oct 4, 2018

Looks good to me - thanks for contributing this!

alex-weaver pushed a commit to alex-weaver/libgit2sharp that referenced this pull request Mar 23, 2023
…s-for-fetch

Wireup http custom headers in fetch options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants