Skip to content

Libgit2Object: make visibility internal #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Libgit2Object: make visibility internal #1316

wants to merge 1 commit into from

Conversation

ethomson
Copy link
Member

@ethomson ethomson commented May 5, 2016 •
edited
Loading

The unit tests are failing because the leak checker is public. See #1312.

@ethomson
Copy link
Member Author

ethomson commented May 5, 2016

It seems that the tests look at this, so this isn't going to without an internalsvisibleto or some other trickery. @niik or @carlosmn do you have clever ideas?

@carlosmn
Copy link
Member

carlosmn commented May 6, 2016

It's a harmless error, but if we're gonna keep this test, I think we should turn to reflection to figure out if LeaksContainer was defined and if so, add it to the list of public objects to ignore.

@ethomson ethomson closed this May 6, 2016
@jcansdale jcansdale mentioned this pull request Nov 20, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethomson @carlosmn