Don't provide a diff notify callback unless necessary #1283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only seem to care about what ends up being collected in the `MatchedPathsAggregator` when we've got some file paths to match agains and either an `OnUnmatchedPath` delegate or instructions to throw on unmatched paths. If none of those condition are true we shouldn't be sending a callback function pointer at all and by not doing so we avoid one marshalled invocation per delta in the diff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only seem to care about what ends up being collected in the
MatchedPathsAggregatorwhen we've got some file paths to match agains and either anOnUnmatchedPathdelegate or instructions to throwon unmatched paths.
If none of those condition are true we shouldn't be sending a callback function pointer at all and by not doing so we avoid one marshalled invocation per delta in the diff.