Explore moving the command-simulating methods to their own namespace #1248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of the methods on Repository are actually trying to replicate git
commands, which makes it harder to see what's the operation vs command.
Move them to their own namespace to make it clear what they're trying to
achieve. We start with a few forms of the git-checkout command.
This shows a possible implementation of this. The
Checkout()
methods on Repository would still need to get deprecated, but they depend on each other in weird ways so we can figure that out if and when we decide to go forward with it.The library itself should also likely get a similar treatment, but it's a lot more annoying to do anything in C, so we start here.
/cc @nulltoken @jamill @whoisj