Fetch with url throws "not a valid remote name".

[VoronFX]

Nothing much to tell, fetch with url is not working.

Example:

Repository.Network.Fetch("https://github.com/libgit2/libgit2sharp.git", new[] { "+refs/remotes/test:refs/heads/master" });

Exception:
InvalidSpecificationException: 'https://github.com/libgit2/libgit2sharp.git' is not a valid remote name.

[ethomson]

It's not supposed to; you can't fetch with a URL. Set up a remote with that URL, then specify the remote name that you've configured.

[VoronFX]

It is supported by libgit2 and I think it's nice feature cause I don't need to setup remote for one time operations. Of course you may not support it, but then it's probably better to change those confusing parameter names and descriptions:

//
// Summary:
//     Fetch from a url with a set of fetch refspecs
//
// Parameters:
//   url:
//     The url to fetch from
//
//   refspecs:
//     The list of resfpecs to use
//
//   options:
//     LibGit2Sharp.FetchOptions controlling fetch behavior
//
//   logMessage:
//     Message to use when updating the reflog.
public virtual void Fetch(string url, IEnumerable<string> refspecs, FetchOptions options, string logMessage);

[ethomson]

Really! I actually didn't know that. What's the API for this in libgit2?

[VoronFX]

Ah sorry, my bad, I've mixed up the docs from git itself and libgit2. Then no complain, but the names still better to fix sometime.

[ethomson]

Okay, thanks for the clarification. I definitely agree with that. I'm going to reopen to make sure that we take care of that. Thanks!

[chescock]

I just hit this error after an update, so I think this is something that LibGit2Sharp used to support.

Looking through the history, I think it broke with #1288. The old version of Fetch had separate overloads that called git_remote_lookup when given a Remote and git_remote_create_anonymous when given a string. The new version first tries git_remote_lookup, and if that returns null then it calls git_remote_create_anonymous.

But URLs contain slashes, and remote names may not contain slashes, so passing a URL to the native git_remote_lookup returns GitErrorCode.InvalidSpecification instead of GitErrorCode.NotFound. That causes Proxy.git_remote_lookup to throw an exception instead of returning null, so the code never reaches the call to git_remote_create_anonymous.

[Ranjankumarrj]

git remote add https-//github.com/Ranjanudt/LatestOfferScreen.git LatestOfferScreen
fatal: 'https-//github.com/Ranjanudt/LatestOfferScreen.git' is not a valid remote name

just put (git remote add origin) after https link pastes it.