Commands.Unstage(repo, filename) no longer works in v0.23.1

[zezba9000]

Commands.Unstage(repo, filename) no longer works in v0.23.1.
It simply does nothing.
This used to work fine in the last version I think.

Commands.Stage(...) works fine.

[ethomson]

Hmm - our integration tests don't seem to indicate a problem. Can you provide a quick snippet and small sample repository that reproduces the problem that you're seeing? Thanks!

[zezba9000]

Here is the download link to the git project: https://www.dropbox.com/s/6aqd1sbphijb1ap/GitRepo.7z?dl=0

Ok so here is a super simple test console app on windows I did to verify the problem:

using LibGit2Sharp;

namespace TestGitLib2Unstage
{
	class Program
	{
		static void Main(string[] args)
		{
			using (var repo = new Repository(@"D:\TEMP\GitRepo"))
			{
				Commands.Unstage(repo, "Yahoo.txt");
			}
		}
	}
}

FYI I see this happen on any repo I try.
0.24.0-pre20170124092542 is also broken as well.
Win10 x64. .NET 4.6.1

[zezba9000]

I've also confirmed this on two different computers.

Just confirmed v0.22.1 is the last version to work using the legacy method:

using LibGit2Sharp;

namespace TestGitLib2Unstage
{
	class Program
	{
		static void Main(string[] args)
		{
			using (var repo = new Repository(@"D:\TEMP\GitRepo"))
			{
				//Commands.Unstage(repo, "Yahoo.txt");
				repo.Unstage("Yahoo.txt");
			}
		}
	}
}

[zezba9000]

Anyone have any ideas on this? Huge blocker for me. EDIT: invoking "git reset myfile" for now.
I can make builds etc if needed.

This is blocking my project: https://github.com/reignstudios/Git-It-GUI
Everything else is working.

[norek]

I've the same problem, I describe it in Issue #1380. I think it's the same problem.

[zezba9000]

I'm pretty sure this is a bug in libgit2 not libgit2sharp. I've looked at the source code and the results are coming directly from the native plugin.

I find it odd one of the most commonly used features has been broken for so long. This is why I wish there was one lib based git project supported by the git team and then a stdin/stdout tool chain was built on top of it. Compilers etc are moving this direction to as we end up having two different projects that do the same thing because the original wasn't designed right :(

[ethomson]

I'm pretty sure this is a bug in libgit2 not libgit2sharp. I've looked at the source code and the results are coming directly from the native plugin.

No; it's a bug in LibGit2Sharp that was introduced with the command refactoring, which is why this worked in previous versions and fails in the current version.

Thanks for reporting this.

[zezba9000]

No; it's a bug in LibGit2Sharp

Ok cool, makes me feel better. Thanks for correcting me.

[ethomson]

Ok cool, makes me feel better. Thanks for correcting me.

This was fixed with #1420 - thanks again for reporting. 😀