Merge pull request #1038 from libgit2/Therzok-remove-forced-connection

Remove manual connection to remote

Author: nulltoken

LibGit2Sharp/Core/NativeMethods.cs

@@ -1026,9 +1026,6 @@ internal static extern int git_remote_delete(
             RepositorySafeHandle repo,
             [MarshalAs(UnmanagedType.CustomMarshaler, MarshalCookie = UniqueId.UniqueIdentifier, MarshalTypeRef = typeof(StrictUtf8Marshaler))] string name);
 
-        [DllImport(libgit2)]
-        internal static extern void git_remote_disconnect(RemoteSafeHandle remote);
-
         [DllImport(libgit2)]
         internal static extern int git_remote_fetch(
             RemoteSafeHandle remote,

LibGit2Sharp/Core/Proxy.cs

@@ -2032,14 +2032,6 @@ public static void git_remote_delete(RepositorySafeHandle repo, string name)
             }
         }
 
-        public static void git_remote_disconnect(RemoteSafeHandle remote)
-        {
-            using (ThreadAffinity())
-            {
-                NativeMethods.git_remote_disconnect(remote);
-            }
-        }
-
         public static GitRefSpecHandle git_remote_get_refspec(RemoteSafeHandle remote, int n)
         {
             return NativeMethods.git_remote_get_refspec(remote, (UIntPtr)n);

LibGit2Sharp/Network.cs

@@ -404,19 +404,11 @@ public virtual void Push(
                 GitRemoteCallbacks gitCallbacks = callbacks.GenerateCallbacks();
                 Proxy.git_remote_set_callbacks(remoteHandle, ref gitCallbacks);
 
-                try
-                {
-                    Proxy.git_remote_connect(remoteHandle, GitDirection.Push);
-                    Proxy.git_remote_push(remoteHandle, pushRefSpecs,
-                        new GitPushOptions()
-                        {
-                            PackbuilderDegreeOfParallelism = pushOptions.PackbuilderDegreeOfParallelism
-                        });
-                }
-                finally
-                {
-                    Proxy.git_remote_disconnect(remoteHandle);
-                }
+                Proxy.git_remote_push(remoteHandle, pushRefSpecs,
+                    new GitPushOptions()
+                    {
+                        PackbuilderDegreeOfParallelism = pushOptions.PackbuilderDegreeOfParallelism
+                    });
             }
         }