bugfix: HTTPS Clone fails with remote pointer not found using Go transport (#836) #842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* create a new remote in the smartTransportCallback incase one is not found
…owner remote is not found in the list of tracked remotes * adding a test to check if external clone via HTTPS works
… network and external hosted repos) * updating go.mod (and go.sum) with the new required dependency on gitkit
lhchavez
reviewed
Oct 21, 2021
Co-authored-by: lhchavez <[email protected]>
Co-authored-by: lhchavez <[email protected]>
|
@lhchavez we have to support go 1.11 also? dunno how to fix those tests also, I hit commit suggestions (once per message) so it actually queued 2 jobs, you can cancel the earliest one |
lhchavez
reviewed
Oct 21, 2021
|
@lhchavez Can you try running this? If it fails, I'll revert the go mod and go sum changes |
please revert them just to keep the deps clean. |
|
Cool, I'll commit in a small while |
* removing gitkit imports
|
@lhchavez please run it now, I have reverted those files |
lhchavez
reviewed
Oct 22, 2021
lhchavez
approved these changes
Oct 23, 2021
|
Thanks a bunch both of you 🙇 |
lhchavez
added a commit
that referenced
this pull request
Nov 9, 2021
…sport (#836) (#842) (#846) Fixes: #836 Changes: * adding a weak bool param for Remote * create a new remote in the smartTransportCallback incase one is not found (cherry picked from commit 0e8009f) Co-authored-by: Yashodhan Ghadge <[email protected]> Co-authored-by: lhchavez <[email protected]>
lhchavez
added a commit
that referenced
this pull request
Nov 9, 2021
…sport (#836) (#842) (#847) Fixes: #836 Changes: * adding a weak bool param for Remote * create a new remote in the smartTransportCallback incase one is not found (cherry picked from commit 0e8009f) Co-authored-by: Yashodhan Ghadge <[email protected]> Co-authored-by: lhchavez <[email protected]>
lhchavez
added a commit
that referenced
this pull request
Nov 9, 2021
…sport (#836) (#842) (#848) Fixes: #836 Changes: * adding a weak bool param for Remote * create a new remote in the smartTransportCallback incase one is not found (cherry picked from commit 0e8009f) Co-authored-by: Yashodhan Ghadge <[email protected]> Co-authored-by: lhchavez <[email protected]>
lhchavez
added a commit
that referenced
this pull request
Nov 9, 2021
…sport (#836) (#842) (#849) Fixes: #836 Changes: * adding a weak bool param for Remote * create a new remote in the smartTransportCallback incase one is not found (cherry picked from commit 0e8009f) Co-authored-by: Yashodhan Ghadge <[email protected]> Co-authored-by: lhchavez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #836
Changes: