-
Couldn't load subscription status.
- Fork 1k
Description
Hello!
First, I want to say thank you for your excellent work on this library. I've been using it in my own demo project, and it has been incredibly convenient.
While working with the callback features (WriteCallBack), I noticed that std::string_view parameters are often passed as const std::string_view&.
I did a search through the project's history to learn more, and I found that you actually mentioned this was a desirable change in [#1081]
It seems no one has submitted a PR for this yet, so I would be happy to take on this task. I'm opening this issue to confirm if you would be open to accepting a PR for this change. I've already started working on this and will submit the PR soon for your review.
Thanks again for this great project!
Possible Solution
before:
std::function<bool(const std::string_view& data, intptr_t userdata)> callback;after:
std::function<bool(std::string_view data, intptr_t userdata)> callback;Alternatives
No response
Additional Context
No response