Skip to content

CSS scroll state container queries and improved function handling #4342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/less/src/less/parser/parser.js
Original file line number Diff line number Diff line change
Expand Up @@ -1884,8 +1884,15 @@ const Parser = function Parser(context, imports, fileInfo, currentIndex) {
let e;
let p;
let rangeP;
let spacing = false;
parserInput.save();
do {
parserInput.save();
if (parserInput.$re(/^[0-9a-z-]*\s+\(/)) {
spacing = true;
}
parserInput.restore();

e = entities.declarationCall.bind(this)() || entities.keyword() || entities.variable() || entities.mixinLookup()
if (e) {
nodes.push(e);
Expand All @@ -1911,8 +1918,13 @@ const Parser = function Parser(context, imports, fileInfo, currentIndex) {
e = p;
} else if (p && e) {
nodes.push(new (tree.Paren)(new (tree.Declaration)(p, e, null, null, parserInput.i + currentIndex, fileInfo, true)));
if (!spacing) {
nodes[nodes.length - 1].noSpacing = true;
}
spacing = false;
} else if (e) {
nodes.push(new(tree.Paren)(e));
spacing = false;
} else {
error('badly formed media feature definition');
}
Expand Down
27 changes: 27 additions & 0 deletions packages/less/src/less/tree/nested-at-rule.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,32 @@ const NestableAtRulePrototype = {
}
},

evalFunction: function () {
if (!this.features || !Array.isArray(this.features.value) || this.features.value.length < 1) {
return;
}

const exprValues = this.features.value;
let expr, paren;

for (let index = 0; index < exprValues.length; ++index) {
expr = exprValues[index];

if (expr.type === 'Keyword' && index + 1 < exprValues.length) {
paren = exprValues[index + 1];

if (paren.type === 'Paren' && paren.noSpacing) {
exprValues[index]= new Expression([expr, paren]);
exprValues.splice(index + 1, 1);
exprValues[index].noSpacing = true;
}
}
}
},

evalTop(context) {
this.evalFunction();

let result = this;

// Render all dependent Media blocks.
Expand All @@ -39,6 +64,8 @@ const NestableAtRulePrototype = {
},

evalNested(context) {
this.evalFunction();

let i;
let value;
const path = context.mediaPath.concat([this]);
Expand Down
8 changes: 7 additions & 1 deletion packages/less/src/less/tree/paren.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,13 @@ Paren.prototype = Object.assign(new Node(), {
},

eval(context) {
return new Paren(this.value.eval(context));
const paren = new Paren(this.value.eval(context));

if (this.noSpacing) {
paren.noSpacing = true;
}

return paren;
}
});

Expand Down
19 changes: 19 additions & 0 deletions packages/test-data/css/_main/container.css
Original file line number Diff line number Diff line change
Expand Up @@ -241,3 +241,22 @@
color: purple;
}
}
#sticky {
position: sticky;
container-type: scroll-state;
}
@container scroll-state(stuck: top) {
#sticky-child {
font-size: 75%;
}
}
@container scroll-state(snapped: x) {
#sticky-child {
font-size: 75%;
}
}
@container scroll-state(scrollable: top) {
#sticky-child {
font-size: 75%;
}
}
23 changes: 23 additions & 0 deletions packages/test-data/less/_main/container.less
Original file line number Diff line number Diff line change
Expand Up @@ -289,3 +289,26 @@
color: purple;
}
}

#sticky {
position: sticky;
container-type: scroll-state;
}

@container scroll-state(stuck: top) {
#sticky-child {
font-size: 75%;
}
}

@container scroll-state(snapped: x) {
#sticky-child {
font-size: 75%;
}
}

@container scroll-state(scrollable: top) {
#sticky-child {
font-size: 75%;
}
}