Skip to content

Fix #3281: console.warning → console.warn #3283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 11, 2018
Merged

Fix #3281: console.warning → console.warn #3283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
753f681
fix #3281 console.warning —> console.warn
calvinjuarez Jul 11, 2018
a6be5ca
lessc – update strict-math deprecation warning to match existing warn…
calvinjuarez Jul 11, 2018
257b49e
Gruntfile – add shell:opts to test lessc option handling
calvinjuarez Jul 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions Gruntfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,21 @@ module.exports = function (grunt) {
benchmark: {
command: 'node benchmark/index.js'
},
opts: { // test running with all current options (using `opts` since `options` means something already)
command: [ // @TODO: make this more thorough
// CURRENT OPTIONS
// --math
'node bin/lessc --math=always test/less/lazy-eval.less tmp/lazy-eval.css',
'node bin/lessc --math=parens-division test/less/lazy-eval.less tmp/lazy-eval.css',
'node bin/lessc --math=parens test/less/lazy-eval.less tmp/lazy-eval.css',
'node bin/lessc --math=strict test/less/lazy-eval.less tmp/lazy-eval.css',
'node bin/lessc --math=strict-legacy test/less/lazy-eval.less tmp/lazy-eval.css',

// DEPRECATED OPTIONS
// --strict-math
'node bin/lessc --strict-math=on test/less/lazy-eval.less tmp/lazy-eval.css',
].join(' && ')
},
plugin: {
command: [
'node bin/lessc --clean-css="--s1 --advanced" test/less/lazy-eval.less tmp/lazy-eval.css',
Expand All @@ -194,12 +209,12 @@ module.exports = function (grunt) {
'node bin/lessc --plugin=clean-css="--s1 --advanced" --plugin=autoprefix="ie 11,Edge >= 13,Chrome >= 47,Firefox >= 45,iOS >= 9.2,Safari >= 9" test/less/lazy-eval.less tmp/lazy-eval.css'
].join(' && ')
},
'sourcemap-test': {
'sourcemap-test': { // quoted value doesn't seem to get picked up by time-grunt, or isn't output, at least; maybe just "sourcemap" is fine?
command: [
'node bin/lessc --source-map=test/sourcemaps/maps/import-map.map test/less/import.less test/sourcemaps/import.css',
'node bin/lessc --source-map test/less/sourcemaps/basic.less test/sourcemaps/basic.css'
].join(' && ')
}
},
},

browserify: {
Expand Down Expand Up @@ -503,6 +518,7 @@ module.exports = function (grunt) {
'clean',
'eslint',
'shell:test',
'shell:opts',
'shell:plugin',
'browsertest'
];
Expand All @@ -518,6 +534,9 @@ module.exports = function (grunt) {
// Run all tests
grunt.registerTask('test', testTasks);

// Run shell option tests (includes deprecated options)
grunt.registerTask('shell-options', ['shell:opts']);

// Run shell plugin test
grunt.registerTask('shell-plugin', ['shell:plugin']);

Expand Down
2 changes: 1 addition & 1 deletion bin/lessc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ function processPluginQueue() {
break;
case 'sm':
case 'strict-math':
console.warning('--strict-math is deprecated. Use --math=strict');
console.warn('The --strict-math option has been deprecated. Use --math=strict.');
if (checkArgFunc(arg, match[2])) {
if (checkBooleanArg(match[2])) {
options.math = MATH.STRICT_LEGACY;
Expand Down