Skip to content

Removes less-rhino (broken for a long time) - Fixes #3241 #3252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 10, 2018
Merged

Removes less-rhino (broken for a long time) - Fixes #3241 #3252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
46c39fa
Removes `less-rhino` (broken for a long time) - Fixes #3241
matthew-dean Jul 2, 2018
740ab6a
Merge branch 'master' into bugfix-remove-rhino
matthew-dean Jul 8, 2018
751335a
Removes remaining Rhino cruft
matthew-dean Jul 8, 2018
9caa77e
Remove rhino files from bower
matthew-dean Jul 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ lessc text eol=lf
*.less text eol=lf
*.css text eol=lf
*.htm text eol=lf
gradlew.bat text eol=crlf
*.html text eol=lf
*.jpg binary
*.png binary
Expand Down
6 changes: 1 addition & 5 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,4 @@ test/sourcemaps/*.css
test/less-bom

# grunt
.grunt

# gradle
.gradle
out
.grunt
1 change: 0 additions & 1 deletion .npmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,3 @@ test/
# re-include test files as they can be useful for plugins that do testing
!test/*.js
tmp/
gradle/
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
## 3.5.3

2018-07-06
- Reverts @media eval change
- Reverts `@media` eval change
- Other bug fixes

## 3.5.0
Expand Down
27 changes: 0 additions & 27 deletions Gruntfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,6 @@ module.exports = function (grunt) {
// Project configuration.
grunt.initConfig({

// Metadata required for build.
build: grunt.file.readYAML('build/build.yml'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about the whole Rhino deal. Was build/build.yml only used for building Less-Rhino? It looks like it was moved to build/build.yml.old anyway. If we're not using the file at all, is there any benefit to keeping it in the repo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was just used for that. I ran the usual grunt tasks and I got no failures. Nor did I see references anywhere else for it. I'll see if I can delete it though.

pkg: grunt.file.readJSON('package.json'),
meta: {
copyright: 'Copyright (c) 2009-<%= grunt.template.today("yyyy") %>',
Expand Down Expand Up @@ -228,24 +226,6 @@ module.exports = function (grunt) {
dist: {
src: '<%= browserify.browser.dest %>',
dest: 'dist/less.js'
},
// Rhino
rhino: {
options: {
banner: '/* Less.js v<%= pkg.version %> RHINO | <%= meta.copyright %>, <%= pkg.author.name %> <<%= pkg.author.email %>> */\n\n',
footer: '' // override task-level footer
},
src: ['<%= build.rhino %>'],
dest: 'dist/less-rhino.js'
},
// lessc for Rhino
rhinolessc: {
options: {
banner: '/* Less.js v<%= pkg.version %> RHINO | <%= meta.copyright %>, <%= pkg.author.name %> <<%= pkg.author.email %>> */\n\n',
footer: '' // override task-level footer
},
src: ['<%= build.rhinolessc %>'],
dest: 'dist/lessc-rhino.js'
}
},

Expand Down Expand Up @@ -471,13 +451,6 @@ module.exports = function (grunt) {
'uglify:dist'
]);

// Release Rhino Version (UNSUPPORTED)
grunt.registerTask('rhino', [
'browserify:rhino',
'concat:rhino',
'concat:rhinolessc'
]);

// Create the browser version of less.js
grunt.registerTask('browsertest-lessjs', [
'browserify:browser',
Expand Down
5 changes: 0 additions & 5 deletions bower.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,13 @@
"**/.*",
"benchmark",
"bin",
"build",
"gradle",
"lib",
"test",
"*.md",
"LICENSE",
"Gruntfile.js",
"*.json",
"*.yml",
"build.gradle",
"gradlew",
"gradlew.bat",
".gitattributes",
".jshintrc",
".npmignore"
Expand Down
Loading