Fix issue (#160) where STYLE elements would not be updated properly in IE < 9 #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like this was closed with a different pull request? |
|
I think regardless, pull requests that cannot be merged should be closed and a second pull request made. Unless there's a better "Github" way to handle un-mergable requests. |
strk
pushed a commit
to CartoDB/carto
that referenced
this pull request
Mar 22, 2013
Includes testcase.
strk
pushed a commit
to CartoDB/carto
that referenced
this pull request
Mar 22, 2013
stefanklug
pushed a commit
to stefanklug/carto
that referenced
this pull request
May 21, 2013
Includes testcase.
stefanklug
pushed a commit
to stefanklug/carto
that referenced
this pull request
May 21, 2013
Quote ampersend chars in XML text. Closes less#263.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like IE doesn't allow updating of a STYLE tag's innerHTML before version 9. Updating the tag's stylesheet property instead, if it exists, falling back to innerHTML if it does not.