throw an error when argument to percentage is not a number #2579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (typeof n !== "number") { | ||
| throw { type: "Argument", message: "argument must be a number" }; | ||
| } | ||
|
|
There was a problem hiding this comment.
Thanks, but there are a number of problems.
First, it fails jscs - the line I'm commenting on has trailing whitespace. You can verify this with grunt jscs
Second, if you look below, we expect n to be of type Dimension, so n.value will be type number
Third, ideally it would be good to get a unit test for this - in the errors sub directory (run tests with grunt test)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix to Issue #2553 . Added an error thrown if the arguments do not equal a number.