Skip to content

Compatibility with Chrome's Sass support #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Compatibility with Chrome's Sass support #1038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02374d5
Make sass-debug-info compatible with DevTools
fgnass Nov 14, 2012
a5c96a4
Test for escaped paths
fgnass Nov 14, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/less/tree.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ tree.debugInfo.asComment = function(ctx) {
};

tree.debugInfo.asMediaQuery = function(ctx) {
return '@media -sass-debug-info{filename{font-family:"' + ctx.debugInfo.fileName + '";}line{font-family:"' + ctx.debugInfo.lineNumber + '";}}\n';
return '@media -sass-debug-info{filename{font-family:' +
('file://' + ctx.debugInfo.fileName).replace(/[\/:.]/g, '\\$&') +
'}line{font-family:\\00003' + ctx.debugInfo.lineNumber + '}}\n';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about the font-family having 3 on it...

Also not sure about the escape.

https://github.com/nex3/sass/blob/master/lib/sass/tree/visitors/to_css.rb#L210

If you know ruby I am pretty sure the answer is here...

https://github.com/nex3/sass/blob/master/lib/sass/scss/rx.rb#L13

};

tree.find = function (obj, fun) {
Expand Down
16 changes: 8 additions & 8 deletions test/css/debug/linenumbers-all.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,43 +1,43 @@
@charset "UTF-8";
/* line 3, {pathimport}test.less */
@media -sass-debug-info{filename{font-family:"{pathimport}test.less";}line{font-family:"3";}}
@media -sass-debug-info{filename{font-family:file\:\/\/{pathimportesc}test\.less}line{font-family:\000033}}
/* @charset "ISO-8859-1"; */
/* line 23, {pathimport}test.less */
@media -sass-debug-info{filename{font-family:"{pathimport}test.less";}line{font-family:"23";}}
@media -sass-debug-info{filename{font-family:file\:\/\/{pathimportesc}test\.less}line{font-family:\0000323}}
.tst3 {
color: grey;
}
/* line 15, {path}linenumbers.less */
@media -sass-debug-info{filename{font-family:"{path}linenumbers.less";}line{font-family:"15";}}
@media -sass-debug-info{filename{font-family:file\:\/\/{pathesc}linenumbers\.less}line{font-family:\0000315}}
.test1 {
color: black;
}
/* line 6, {path}linenumbers.less */
@media -sass-debug-info{filename{font-family:"{path}linenumbers.less";}line{font-family:"6";}}
@media -sass-debug-info{filename{font-family:file\:\/\/{pathesc}linenumbers\.less}line{font-family:\000036}}
.test2 {
color: red;
}
@media all {
/* line 5, {pathimport}test.less */
@media -sass-debug-info{filename{font-family:"{pathimport}test.less";}line{font-family:"5";}}
@media -sass-debug-info{filename{font-family:file\:\/\/{pathimportesc}test\.less}line{font-family:\000035}}
.tst {
color: black;
}
}
@media all and screen {
/* line 7, {pathimport}test.less */
@media -sass-debug-info{filename{font-family:"{pathimport}test.less";}line{font-family:"7";}}
@media -sass-debug-info{filename{font-family:file\:\/\/{pathimportesc}test\.less}line{font-family:\000037}}
.tst {
color: red;
}
/* line 9, {pathimport}test.less */
@media -sass-debug-info{filename{font-family:"{pathimport}test.less";}line{font-family:"9";}}
@media -sass-debug-info{filename{font-family:file\:\/\/{pathimportesc}test\.less}line{font-family:\000039}}
.tst .tst3 {
color: white;
}
}
/* line 18, {pathimport}test.less */
@media -sass-debug-info{filename{font-family:"{pathimport}test.less";}line{font-family:"18";}}
@media -sass-debug-info{filename{font-family:file\:\/\/{pathimportesc}test\.less}line{font-family:\0000318}}
.tst2 {
color: white;
}
16 changes: 8 additions & 8 deletions test/css/debug/linenumbers-mediaquery.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,35 +1,35 @@
@charset "UTF-8";
@media -sass-debug-info{filename{font-family:"{pathimport}test.less";}line{font-family:"3";}}
@media -sass-debug-info{filename{font-family:file\:\/\/{pathimportesc}test\.less}line{font-family:\000033}}
/* @charset "ISO-8859-1"; */
@media -sass-debug-info{filename{font-family:"{pathimport}test.less";}line{font-family:"23";}}
@media -sass-debug-info{filename{font-family:file\:\/\/{pathimportesc}test\.less}line{font-family:\0000323}}
.tst3 {
color: grey;
}
@media -sass-debug-info{filename{font-family:"{path}linenumbers.less";}line{font-family:"15";}}
@media -sass-debug-info{filename{font-family:file\:\/\/{pathesc}linenumbers\.less}line{font-family:\0000315}}
.test1 {
color: black;
}
@media -sass-debug-info{filename{font-family:"{path}linenumbers.less";}line{font-family:"6";}}
@media -sass-debug-info{filename{font-family:file\:\/\/{pathesc}linenumbers\.less}line{font-family:\000036}}
.test2 {
color: red;
}
@media all {
@media -sass-debug-info{filename{font-family:"{pathimport}test.less";}line{font-family:"5";}}
@media -sass-debug-info{filename{font-family:file\:\/\/{pathimportesc}test\.less}line{font-family:\000035}}
.tst {
color: black;
}
}
@media all and screen {
@media -sass-debug-info{filename{font-family:"{pathimport}test.less";}line{font-family:"7";}}
@media -sass-debug-info{filename{font-family:file\:\/\/{pathimportesc}test\.less}line{font-family:\000037}}
.tst {
color: red;
}
@media -sass-debug-info{filename{font-family:"{pathimport}test.less";}line{font-family:"9";}}
@media -sass-debug-info{filename{font-family:file\:\/\/{pathimportesc}test\.less}line{font-family:\000039}}
.tst .tst3 {
color: white;
}
}
@media -sass-debug-info{filename{font-family:"{pathimport}test.less";}line{font-family:"18";}}
@media -sass-debug-info{filename{font-family:file\:\/\/{pathimportesc}test\.less}line{font-family:\0000318}}
.tst2 {
color: white;
}
9 changes: 7 additions & 2 deletions test/less-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,13 @@ runTestSet({dumpLineNumbers: 'all'}, "debug/", null,
function(name) { return name + '-all'; });

function globalReplacements(input, directory) {
return input.replace(/\{path\}/g, path.join(process.cwd(), directory))
.replace(/\{pathimport\}/g, path.join(process.cwd(), directory + "import/"))
var p = path.join(process.cwd(), directory);
var pesc = p.replace(/[.:\/]/g, '\\$&');

return input.replace(/\{path\}/g, p)
.replace(/\{pathesc\}/g, pesc)
.replace(/\{pathimport\}/g, p+"import/")
.replace(/\{pathimportesc\}/g, pesc + "import\\/")
.replace(/\r\n/g, '\n');
}

Expand Down