Skip to content

sync: update ggml #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

sync: update ggml #509

wants to merge 2 commits into from

Conversation

stduhpf
Copy link
Contributor

@stduhpf stduhpf commented Dec 4, 2024

Mostly fixes and optimisations, especially for Vulkan backends.
(Fixes #439 for example)
Edit (13/02/25): updated again, now even more issues seem to be fixed

@stduhpf
Copy link
Contributor Author

stduhpf commented Dec 6, 2024

Oh, I think this breaks Q2_K and Q3_K quants on Vulkan. At least on my GPU.
Reverting ggml-org/ggml@941c450 fixes it for me.

@daniandtheweb
Copy link
Contributor

daniandtheweb commented Jan 8, 2025

I've tried applying these changes and syncing ggml to the latest commit and vulkan image generation seems to be broken. I think it may be worth taking a look at it, some of the latest ggml changes supposedly greatly improve stable-diffusion.cpp's performance.

@daniandtheweb
Copy link
Contributor

The issue that this sync has is that the main program can't autodetect the weight type anymore.
When manually specifying the type the program runs as expected (on my card the speed for 512x512 sd 1.5 goes from 1.37 it/s to 1.44 it/s with the latest changes on upstream ggml).

@stduhpf
Copy link
Contributor Author

stduhpf commented Jan 10, 2025

Yeah this PR isn't up to date with the lastest GGML changes. ggml types have been changed again ,so enum sd_type_t in stable-diffusion.h needs to be updated for it to work with lastest GGML.

@stduhpf stduhpf force-pushed the sync branch 2 times, most recently from bcb0b27 to 3f5000e Compare February 13, 2025 17:52
fix missing header
@stduhpf stduhpf marked this pull request as ready for review February 13, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Corrupted images on Vukan backend
2 participants